commit e4bae57619ea0dd6eb4b2a571b0b44715dfe3cc9
parent 81ef677bf225a3d48d84db0f88e67f2d7a8297d8
Author: William Casarin <jb55@jb55.com>
Date: Thu, 17 Apr 2025 08:39:47 -0700
refactor: ocd unnecessary pass by value
Signed-off-by: William Casarin <jb55@jb55.com>
Diffstat:
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/crates/notedeck_columns/src/ui/profile/mod.rs b/crates/notedeck_columns/src/ui/profile/mod.rs
@@ -176,7 +176,10 @@ impl<'a, 'd> ProfileView<'a, 'd> {
ui.add_space(18.0);
- ui.add(display_name_widget(get_display_name(Some(&profile)), false));
+ ui.add(display_name_widget(
+ &get_display_name(Some(&profile)),
+ false,
+ ));
ui.add_space(8.0);
@@ -340,7 +343,10 @@ fn edit_profile_button() -> impl egui::Widget + 'static {
}
}
-fn display_name_widget(name: NostrName<'_>, add_placeholder_space: bool) -> impl egui::Widget + '_ {
+fn display_name_widget<'a>(
+ name: &'a NostrName<'a>,
+ add_placeholder_space: bool,
+) -> impl egui::Widget + 'a {
move |ui: &mut egui::Ui| -> egui::Response {
let disp_resp = name.display_name.map(|disp_name| {
ui.add(
diff --git a/crates/notedeck_columns/src/ui/profile/preview.rs b/crates/notedeck_columns/src/ui/profile/preview.rs
@@ -45,7 +45,7 @@ impl<'a, 'cache> ProfilePreview<'a, 'cache> {
.border(ProfilePic::border_stroke(ui)),
);
ui.add(display_name_widget(
- get_display_name(Some(self.profile)),
+ &get_display_name(Some(self.profile)),
false,
));
ui.add(about_section_widget(self.profile));
@@ -94,7 +94,7 @@ impl egui::Widget for SimpleProfilePreview<'_, '_> {
.show(ui, |ui| {
ui.add(ProfilePic::new(self.cache, get_profile_url(self.profile)).size(48.0));
ui.vertical(|ui| {
- ui.add(display_name_widget(get_display_name(self.profile), true));
+ ui.add(display_name_widget(&get_display_name(self.profile), true));
if !self.is_nsec {
ui.add(
Label::new(