commit 86d2a9e2e78b4d20503c67cea8b6362ff4341f05
parent c469a0ff221cd66d9a518e3f90452b7d7bd90f1d
Author: William Casarin <jb55@jb55.com>
Date: Wed, 14 May 2025 09:56:06 -0700
clippy: fix lint related to iterator
warning: called `Iterator::last` on a `DoubleEndedIterator`; this will
needlessly iterate the entire iterator
--> crates/notedeck/src/urls.rs:262:43
|
262 | if let Some(file_name) = path.last() {
| ^^^^^^ help: try: `next_back()`
|
Signed-off-by: William Casarin <jb55@jb55.com>
Diffstat:
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/crates/notedeck/src/urls.rs b/crates/notedeck/src/urls.rs
@@ -258,8 +258,8 @@ fn is_mime_supported(mime: &mime_guess::Mime) -> bool {
fn url_has_supported_mime(url: &str) -> MimeHostedAtUrl {
if let Ok(url) = Url::parse(url) {
- if let Some(path) = url.path_segments() {
- if let Some(file_name) = path.last() {
+ if let Some(mut path) = url.path_segments() {
+ if let Some(file_name) = path.next_back() {
if let Some(ext) = std::path::Path::new(file_name)
.extension()
.and_then(|ext| ext.to_str())