notedeck

commit 2dcc323b12183e826f2c5f5bdb54937c805fa82b
parent 7caf4971f7665f2e06c95b3176aff163bf01a81d
Author: William Casarin <jb55@jb55.com>
Date:   Thu, 26 Feb 2026 13:21:04 -0800

dave: fix markdown tables breaking layout on small screens

Wrap tables in a horizontal ScrollArea so wide tables scroll
instead of overflowing the chat area. Column::auto() lets columns
grow to content width with no upper bound, which is fine on wide
screens but breaks the layout on narrow ones.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Diffstat:
M
crates/notedeck_dave/src/ui/markdown_ui.rs
 | 
64
+++++++++++++++++++++++++++++++++++-----------------------------

1 file changed, 35 insertions(+), 29 deletions(-)
diff --git a/crates/notedeck_dave/src/ui/markdown_ui.rs b/crates/notedeck_dave/src/ui/markdown_ui.rs
@@ -500,41 +500,47 @@ fn render_table(headers: &[Span], rows: &[Vec<Span>], theme: &MdTheme, buffer: &
 
     // Use first header's byte offset as id_salt so multiple tables don't clash
     let salt = headers.first().map_or(0, |h| h.start);
-    let mut builder = TableBuilder::new(ui)
-        .id_salt(salt)
-        .vscroll(false)
-        .auto_shrink([false, false]);
-    for _ in 0..num_cols {
-        builder = builder.column(Column::auto().resizable(true));
-    }
-
-    let header_bg = theme.code_bg;
-
-    builder
-        .header(28.0, |mut header| {
-            for h in headers {
-                header.col(|ui| {
-                    ui.painter().rect_filled(ui.max_rect(), 0.0, header_bg);
-                    egui::Frame::NONE.inner_margin(cell_padding).show(ui, |ui| {
-                        ui.strong(h.resolve(buffer));
-                    });
-                });
+
+    // Wrap in horizontal scroll so wide tables don't break layout on small screens
+    egui::ScrollArea::horizontal()
+        .id_salt(("md_table_scroll", salt))
+        .show(ui, |ui| {
+            let mut builder = TableBuilder::new(ui)
+                .id_salt(salt)
+                .vscroll(false)
+                .auto_shrink([false, false]);
+            for _ in 0..num_cols {
+                builder = builder.column(Column::auto().resizable(true));
             }
-        })
-        .body(|mut body| {
-            for row in rows {
-                body.row(28.0, |mut table_row| {
-                    for i in 0..num_cols {
-                        table_row.col(|ui| {
+
+            let header_bg = theme.code_bg;
+
+            builder
+                .header(28.0, |mut header| {
+                    for h in headers {
+                        header.col(|ui| {
+                            ui.painter().rect_filled(ui.max_rect(), 0.0, header_bg);
                             egui::Frame::NONE.inner_margin(cell_padding).show(ui, |ui| {
-                                if let Some(cell) = row.get(i) {
-                                    ui.label(cell.resolve(buffer));
-                                }
+                                ui.strong(h.resolve(buffer));
                             });
                         });
                     }
+                })
+                .body(|mut body| {
+                    for row in rows {
+                        body.row(28.0, |mut table_row| {
+                            for i in 0..num_cols {
+                                table_row.col(|ui| {
+                                    egui::Frame::NONE.inner_margin(cell_padding).show(ui, |ui| {
+                                        if let Some(cell) = row.get(i) {
+                                            ui.label(cell.resolve(buffer));
+                                        }
+                                    });
+                                });
+                            }
+                        });
+                    }
                 });
-            }
         });
     ui.add_space(8.0);
 }