damus

commit 76a6dbc4060caa2ad33d84a3321fc47b24252c2f
parent 1b1d4bd6d1e3b53c2986dfbee4cad53b9e992d64
Author: William Casarin <jb55@jb55.com>
Date:   Sun, 10 Sep 2023 18:22:48 -0700

perf: remove unused zstack on like button

Diffstat:
M
damus/Views/ActionBar/EventActionBar.swift
 | 
36
+++++++++++++++---------------------

1 file changed, 15 insertions(+), 21 deletions(-)
diff --git a/damus/Views/ActionBar/EventActionBar.swift b/damus/Views/ActionBar/EventActionBar.swift
@@ -198,27 +198,6 @@ struct LikeButton: View {
     }
 
     var body: some View {
-        ZStack {
-            likeButton()
-                .accessibilityLabel(NSLocalizedString("Like", comment: "Accessibility Label for Like button"))
-                .rotationEffect(Angle(degrees: shouldAnimate ? rotationAngle : 0))
-                .onReceive(self.timer) { _ in
-                    shakaAnimationLogic()
-                }
-                .simultaneousGesture(longPressGesture())
-                .highPriorityGesture(TapGesture().onEnded {
-                    guard !isReactionsVisible else { return }
-                    withAnimation(Animation.easeOut(duration: 0.15)) {
-                        self.action(damus_state.settings.default_emoji_reaction)
-                        shouldAnimate = true
-                        amountOfAngleIncrease = 20.0
-                    }
-                })
-                .overlay(reactionsOverlay())
-        }
-    }
-
-    func likeButton() -> some View {
         Group {
             if let liked_emoji {
                 buildMaskView(for: liked_emoji)
@@ -231,6 +210,21 @@ struct LikeButton: View {
                     .foregroundColor(.gray)
             }
         }
+        .accessibilityLabel(NSLocalizedString("Like", comment: "Accessibility Label for Like button"))
+        .rotationEffect(Angle(degrees: shouldAnimate ? rotationAngle : 0))
+        .onReceive(self.timer) { _ in
+            shakaAnimationLogic()
+        }
+        .simultaneousGesture(longPressGesture())
+        .highPriorityGesture(TapGesture().onEnded {
+            guard !isReactionsVisible else { return }
+            withAnimation(Animation.easeOut(duration: 0.15)) {
+                self.action(damus_state.settings.default_emoji_reaction)
+                shouldAnimate = true
+                amountOfAngleIncrease = 20.0
+            }
+        })
+        .overlay(reactionsOverlay())
     }
 
     func shakaAnimationLogic() {