commit 26df547605a21bd634b32a5c9190511d90a8e877
parent a97532b90d12edf82436c9ec0c735ce436f2f5f6
Author: Terry Yiu <git@tyiu.xyz>
Date: Sun, 19 Jan 2025 13:21:31 -0500
Remove language filtering from Universe feed because language detection can be inaccurate
Changelog-Removed: Removed language filtering from Universe feed because language detection can be inaccurate
Signed-off-by: Terry Yiu <git@tyiu.xyz>
Diffstat:
3 files changed, 1 insertion(+), 18 deletions(-)
diff --git a/damus/Models/UserSettingsStore.swift b/damus/Models/UserSettingsStore.swift
@@ -185,9 +185,6 @@ class UserSettingsStore: ObservableObject {
@Setting(key: "show_music_statuses", default_value: true)
var show_music_statuses: Bool
-
- @Setting(key: "show_only_preferred_languages", default_value: false)
- var show_only_preferred_languages: Bool
@Setting(key: "multiple_events_per_pubkey", default_value: false)
var multiple_events_per_pubkey: Bool
diff --git a/damus/Views/SearchHomeView.swift b/damus/Views/SearchHomeView.swift
@@ -62,18 +62,7 @@ struct SearchHomeView: View {
return false
}
- if damus_state.settings.show_only_preferred_languages == false {
- return true
- }
-
- // If we can't determine the note's language with 50%+ confidence, lean on the side of caution and show it anyway.
- let note_lang = damus_state.events.get_cache_data(ev.id).translations_model.note_language
- guard let note_lang else {
- return true
- }
-
- let currentLanguage = localeToLanguage(Locale.current.identifier)
- return currentLanguage == note_lang
+ return true
},
content: {
AnyView(VStack {
diff --git a/damus/Views/Settings/TranslationSettingsView.swift b/damus/Views/Settings/TranslationSettingsView.swift
@@ -16,9 +16,6 @@ struct TranslationSettingsView: View {
var body: some View {
Form {
Section(NSLocalizedString("Translations", comment: "Section title for selecting the translation service.")) {
- Toggle(NSLocalizedString("Show only preferred languages on Universe feed", comment: "Toggle to show notes that are only in the device's preferred languages on the Universe feed and hide notes that are in other languages."), isOn: $settings.show_only_preferred_languages)
- .toggleStyle(.switch)
-
Picker(NSLocalizedString("Service", comment: "Prompt selection of translation service provider."), selection: $settings.translation_service) {
ForEach(TranslationService.allCases.filter({ damus_state.purple.enable_purple ? true : $0 != .purple }), id: \.self) { server in
Text(server.model.displayName)